Fix #45, use separate dispatcher for messages #49
Conversation
|
You have successfully added a new CodeQL configuration |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* Process a command pipe message */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void HK_AppPipe(const CFE_SB_Buffer_t *BufPtr) |
Check notice
Code scanning / CodeQL
Long function without assertion
| /* Noop command */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void HK_NoopVerifyDispatch(const CFE_SB_Buffer_t *BufPtr) |
Check notice
Code scanning / CodeQL
Long function without assertion
| /* Reset counters command */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void HK_ResetCountersVerifyDispatch(const CFE_SB_Buffer_t *BufPtr) |
Check notice
Code scanning / CodeQL
Long function without assertion
| /* Verify Command Length */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| int32 HK_VerifyCmdLength(const CFE_SB_Buffer_t *BufPtr, size_t ExpectedLength) |
Check notice
Code scanning / CodeQL
Long function without assertion
| /* Verify Non-Command Msg Length (Event is differnt) */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| int32 HK_VerifyMsgLength(const CFE_SB_Buffer_t *BufPtr, size_t ExpectedLength) |
Check notice
Code scanning / CodeQL
Long function without assertion
| @@ -404,7 +321,7 @@ | |||
| /* Housekeeping request */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| void HK_HousekeepingCmd(const CFE_MSG_CommandHeader_t *Msg) | |||
| void HK_SendHkCmd(const CFE_SB_Buffer_t *BufPtr) | |||
Check notice
Code scanning / CodeQL
Long function without assertion
|
You have successfully added a new CodeQL configuration |
Isolate the message verification and dispatch from the general message processing. Functions in the "cmds" file now strictly handle the command content, and do not get involved in general validation. The "Custom" code isolation is also in a separate dispatcher. There is a separate issue to address this.
jphickey
force-pushed
the
fix-45-dispatch
branch
from
f3e47a0
to
0d1ccc1
Compare
|
Updated to address format check and documentation |
Checklist (Please check before submitting)
Describe the contribution
Isolate the message verification and dispatch from the general message processing. Functions in the "cmds" file now strictly handle the command content, and do not get involved in general validation.
The "Custom" code isolation is also in a separate dispatcher. There is a separate issue to address this.
Fixes #45
Testing performed
Build and run HK in CFE and run all tests
Expected behavior changes
No change in actual implementation, splits up source files into smaller units only
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.