Fix #87, Combine consecutive, mutually-exclusive status checks #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-87-combine-mutually-exclusive-status-checks
branch
2 times, most recently
from
26683ab
to
a3a2ca1
Compare
thnkslprpt
force-pushed
the
fix-87-combine-mutually-exclusive-status-checks
branch
from
a3a2ca1
to
d36e499
Compare
dmknutsen
approved these changes
Apr 6, 2023
|
@thnkslprpt CCB 6 April 2023: Would you be able to resolve the merge conflicts? |
thnkslprpt
force-pushed
the
fix-87-combine-mutually-exclusive-status-checks
branch
from
d36e499
to
95a73f0
Compare
thnkslprpt
force-pushed
the
fix-87-combine-mutually-exclusive-status-checks
branch
from
95a73f0
to
52ebdb7
Compare
All cleared up now @dzbaker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #87
Consecutive, mutually-exclusive status checks (two
ifs) were combined into a singleif/else.Also cleared up a few out-of-place empty lines and minor typos in the same file.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt