Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine consecutive mutually exclusive status checks into an if/else #87

Closed
2 tasks done
thnkslprpt opened this issue Mar 6, 2023 · 0 comments · Fixed by #88
Closed
2 tasks done

Combine consecutive mutually exclusive status checks into an if/else #87

thnkslprpt opened this issue Mar 6, 2023 · 0 comments · Fixed by #88

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
DS_AppInitialize contains consecutive, mutually exclusive status checks.

Code snips

DS/fsw/src/ds_app.c

Lines 202 to 211 in 04c0154

if (Result != CFE_SUCCESS)
{
CFE_EVS_SendEvent(DS_INIT_ERR_EID, CFE_EVS_EventType_ERROR, "Unable to register for EVS services, err = 0x%08X",
(unsigned int)Result);
}
/*
** Create application Software Bus message pipe...
*/
if (Result == CFE_SUCCESS)

Expected behavior
Combine into an if/else - no need to do 2 evaluations.

Reporter Info
Avi Weiss @thnkslprpt

dzbaker added a commit that referenced this issue Apr 6, 2023
…ive-status-checks

Fix #87, Combine consecutive, mutually-exclusive status checks
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants