Fix #139, Remove use of message storage in CF_AppData global #371
+203
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-139-remove-use-of-message-storage-in-cf-global
branch
from
ea551c5
to
bb4ad62
Compare
chillfig
approved these changes
Apr 5, 2023
thnkslprpt
deleted the
fix-139-remove-use-of-message-storage-in-cf-global
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #139
Removed the only remaining use of the global data structure to store the message buffer. No longer required and all tests passing without need for it.
Some typos and capitalizations of acronyms added along with this PR.
Code changes are in
cf_cfdp_sbintf.c. The rest are typos/comments amendments.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt