Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing nuxt module build error #452

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented May 30, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Fixes nuxt module build script and issue with importing the vite config from @explorer-1/vue

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle marked this pull request as draft May 30, 2024 22:37
@github-actions github-actions bot added the bug Something isn't working label May 30, 2024
@stephiescastle stephiescastle changed the title using createResolver fixing nuxt module build error May 30, 2024
@stephiescastle stephiescastle marked this pull request as ready for review May 30, 2024 23:56
@stephiescastle stephiescastle requested a review from jamesray May 30, 2024 23:56
@stephiescastle stephiescastle enabled auto-merge (squash) May 31, 2024 00:31
@stephiescastle stephiescastle merged commit 428feed into main May 31, 2024
1 check passed
@stephiescastle stephiescastle deleted the fix/filepaths-in-dependencies branch May 31, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants