Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links to stories within storybook #430

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Fixes broken links in our hosted Storybook: https://nasa-jpl.github.io/explorer-1/ (a regression from #428)

Instructions to test

  1. npm run build-storybook
  2. python3 -m http.server 9000
  3. view http://localhost:9000/storybook_compiled/?path=/docs/components-blocks-overview--docs
  4. click on links to the individual stories (the underlined heading for each block)
  5. the link should work

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added bug Something isn't working storybook This issue relates to Storybook.js labels May 15, 2024
@stephiescastle stephiescastle requested a review from jamesray May 15, 2024 02:08
@stephiescastle stephiescastle added maintenance The meta work of maintaining the project bug Something isn't working and removed bug Something isn't working maintenance The meta work of maintaining the project labels May 15, 2024
@stephiescastle stephiescastle merged commit 56fc316 into main May 15, 2024
1 check passed
@stephiescastle stephiescastle deleted the fix/linking-to-stories branch May 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants