Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Comet-style server side filtering #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Sep 3, 2024

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (e453216) to head (9c501a9).

Files with missing lines Patch % Lines
gcn/voeventclient.py 54.54% 5 Missing ⚠️
gcn/cmdline.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   72.76%   71.69%   -1.07%     
==========================================
  Files           5        5              
  Lines         257      265       +8     
==========================================
+ Hits          187      190       +3     
- Misses         70       75       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant