fix(nestjs): fix memoize util

nartc · Mar 16, 2021 · e56887b · e56887b
1 parent 76a817b
commit e56887b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/packages/nestjs/src/lib/pipes/map.pipe.ts b/packages/nestjs/src/lib/pipes/map.pipe.ts
@@ -48,7 +48,7 @@ function createMapPipe(
           );
         }
 
-        return this.mapper.map(
+        return this.mapper?.map(
           value,
           to as any,
           from as any,

diff --git a/packages/nestjs/src/lib/utils/memoize.util.ts b/packages/nestjs/src/lib/utils/memoize.util.ts
@@ -5,11 +5,15 @@ export function memoize(fn: Function) {
   const cache: Record<string, unknown> = {};
   return (...args: any[]) => {
     const n =
-      args.reduce(
-        (key, arg) =>
-          key.concat('|', typeof arg === 'string' ? arg : arg.toString()),
-        ''
-      ) || defaultKey;
+      args.reduce((key, arg) => {
+        const argToConcat =
+          typeof arg === 'string'
+            ? arg
+            : typeof arg === 'object'
+            ? JSON.stringify(arg)
+            : arg.toString();
+        return key.concat('|', argToConcat);
+      }, '') || defaultKey;
     if (n in cache) {
       return cache[n];
     }

diff --git a/packages/nestjs/src/lib/utils/transform.util.ts b/packages/nestjs/src/lib/utils/transform.util.ts
@@ -2,7 +2,7 @@ import { isEmpty } from '@automapper/core';
 import type { MapOptions, Mapper } from '@automapper/types';
 
 export function shouldSkipTransform(
-  mapper: Mapper,
+  mapper: Mapper | undefined,
   to: unknown,
   from: unknown
 ): boolean {
@@ -11,19 +11,19 @@ export function shouldSkipTransform(
 
 export function transformArray(
   value: unknown,
-  mapper: Mapper,
+  mapper: Mapper | undefined,
   to: any,
   from: any,
   options?: MapOptions
 ) {
   if (!Array.isArray(value)) return value;
-  return mapper.mapArray(value, to, from, options);
+  return mapper?.mapArray(value, to, from, options);
 }
 
 export function getTransformOptions(
   options?: { isArray?: boolean; mapperName?: string } & MapOptions
 ): {
-  mapperName: string;
+  mapperName?: string;
   isArray: boolean;
   transformedMapOptions?: MapOptions;
 } {