fix(pojos): adjust code smell

nartc · Jan 30, 2021 · 4682fbf · 4682fbf
1 parent 3b0550d
commit 4682fbf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/pojos/src/lib/storages/pojos-metadata.storage.ts b/packages/pojos/src/lib/storages/pojos-metadata.storage.ts
@@ -33,7 +33,7 @@ export class PojosMetadataStorage implements MetadataStorage<string> {
     while (i--) {
       const metadata = metadataList[i];
       // skip existing
-      if (resultMetadataList.some(([metaKey]) => metaKey === metadata[0])) {
+      if (resultMetadataList.some(([key]) => key === metadata[0])) {
         continue;
       }
       resultMetadataList.push(metadataList[i]);
@@ -46,7 +46,9 @@ export class PojosMetadataStorage implements MetadataStorage<string> {
     metaKey: string,
     key: string
   ): Metadata<string> | undefined {
-    return this.getMetadata(metaKey).find(([metaKey]) => metaKey === key);
+    return this.getMetadata(metaKey).find(
+      ([innerMetaKey]) => innerMetaKey === key
+    );
   }
 
   has(metaKey: string): boolean {

diff --git a/packages/pojos/src/lib/utils/instantiate.util.ts b/packages/pojos/src/lib/utils/instantiate.util.ts
@@ -46,8 +46,12 @@ export function instantiate<TModel extends Dictionary<TModel>>(
     }
 
     if (isDefined(valueAtKey)) {
-      const [result] = instantiate(metadataStorage, metaResult, valueAtKey);
-      obj[key] = result;
+      const [instantiateResult] = instantiate(
+        metadataStorage,
+        metaResult,
+        valueAtKey
+      );
+      obj[key] = instantiateResult;
       continue;
     }