Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Added check for isDevMode in the security plugin #144

Merged

Conversation

prisis
Copy link
Member

@prisis prisis commented Nov 3, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

feat : using isDevMode to check if security should check dev dependencies
build : changed how mirror classes list is build

…cies

build : changed how mirror classes list is build
@prisis prisis added the Fixed Changelog Fixed label Nov 3, 2019
@prisis prisis added this to the v1.0.0 milestone Nov 3, 2019
@prisis prisis force-pushed the feat/using-isDevMode-for-security-check branch from 53912f6 to 3149341 Compare November 3, 2019 22:07
@prisis prisis changed the title Added checkc for isDevMode in the security plugin Added check for isDevMode in the security plugin Nov 4, 2019
fix : added security alias file to ignore in phpunit.xml
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #144 into master will increase coverage by 0.45%.
The diff coverage is 67.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
+ Coverage     71.49%   71.95%   +0.45%     
- Complexity      860      869       +9     
============================================
  Files            57       57              
  Lines          2298     2328      +30     
============================================
+ Hits           1643     1675      +32     
+ Misses          655      653       -2
Impacted Files Coverage Δ Complexity Δ
...rc/Common/Traits/GetGenericPropertyReaderTrait.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Prefetcher/Prefetcher.php 0% <0%> (ø) 40 <0> (ø) ⬇️
src/Automatic/Operation/Uninstall.php 90.9% <0%> (ø) 7 <0> (ø) ⬇️
src/Prefetcher/TruncatedComposerRepository.php 0% <0%> (ø) 6 <0> (+2) ⬆️
...utomatic/Configurator/Traits/AppendToFileTrait.php 100% <100%> (ø) 5 <0> (ø) ⬇️
...matic/Configurator/ComposerScriptsConfigurator.php 98.41% <100%> (ø) 22 <0> (ø) ⬇️
src/Automatic/QuestionFactory.php 100% <100%> (ø) 8 <0> (ø) ⬇️
src/Automatic/AbstractConfigurator.php 100% <100%> (ø) 13 <0> (ø) ⬇️
...c/Automatic/Configurator/GitIgnoreConfigurator.php 100% <100%> (ø) 7 <0> (ø) ⬇️
src/Common/Traits/ExpandTargetDirTrait.php 100% <100%> (ø) 3 <0> (ø) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e2223...ef55ebd. Read the comment docs.

@prisis prisis merged commit 8467d12 into narrowspark:master Nov 4, 2019
@prisis prisis deleted the feat/using-isDevMode-for-security-check branch November 4, 2019 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed Changelog Fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant