-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npe2 conversion (napari plugin engine 2) #11
Conversation
For some reason it's not detecting that I merged #10, would you mind merging in main manually (or git rebasing on main) so only the relevant changes are visible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove the napari-plugin-engine dependency, imports, and decorators? I think the convert script still assumes that one wants to support both npe1 and npe2, but that is definitely not the case anymore.
Done. Do I need to add |
No, since we don't import from npe2! We will need to add the yml to the manifest, but let me do that in a separate PR where I plan to update setup.py to pyproject.toml. |
(Unless you want to do it here so it stays consistent...) |
What do you prefer? (I did make an issue here about pyproject.toml #13) |
I don't mind leaving it till the fix of #13. In we go! 😊 |
Migration to the new napari plugin engine 2 spec, see https://napari.org/stable/plugins/npe2_migration_guide.html#migrating-using-the-npe2-command-line-tool