Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npe2 conversion (napari plugin engine 2) #11

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

GenevieveBuckley
Copy link
Collaborator

@jni
Copy link
Member

jni commented Feb 14, 2024

For some reason it's not detecting that I merged #10, would you mind merging in main manually (or git rebasing on main) so only the relevant changes are visible?

Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the napari-plugin-engine dependency, imports, and decorators? I think the convert script still assumes that one wants to support both npe1 and npe2, but that is definitely not the case anymore.

@GenevieveBuckley
Copy link
Collaborator Author

Can you also remove the napari-plugin-engine dependency, imports, and decorators? I think the convert script still assumes that one wants to support both npe1 and npe2, but that is definitely not the case anymore.

Done. Do I need to add npe2 to the requirements.txt file?

@jni
Copy link
Member

jni commented Feb 14, 2024

Do I need to add npe2 to the requirements.txt file?

No, since we don't import from npe2!

We will need to add the yml to the manifest, but let me do that in a separate PR where I plan to update setup.py to pyproject.toml.

@jni
Copy link
Member

jni commented Feb 14, 2024

(Unless you want to do it here so it stays consistent...)

@GenevieveBuckley
Copy link
Collaborator Author

What do you prefer? (I did make an issue here about pyproject.toml #13)

@jni
Copy link
Member

jni commented Feb 14, 2024

I don't mind leaving it till the fix of #13. In we go! 😊

@jni jni merged commit 8c4915b into napari:main Feb 14, 2024
@GenevieveBuckley GenevieveBuckley deleted the npe2-convert branch February 14, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants