-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toolbutton to select action from direct entry install #96
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 93.09% 93.57% +0.48%
==========================================
Files 10 10
Lines 1781 1822 +41
==========================================
+ Hits 1658 1705 +47
+ Misses 123 117 -6 ☔ View full report in Codecov by Sentry. |
24b5a3a
to
4eb1367
Compare
4eb1367
to
187b811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a check on Windows and seems like things are working:
- pip installed napari case:
- conda installed napari case:
However, for the conda case, it took my a moment to realize that I had to hold the button for the menu to show up:
I think that instead of setting self.direct_entry_btn.setToolButtonStyle(Qt.ToolButtonTextBesideIcon)
we could set the toolbutton popupMode
to QToolButton.MenuButtonPopup
. That should enable the toolbutton to trigger the menu by clicking an arrow that gets added to the toolbutton. Left a suggestion for that in case clicking instead of holding makes more sense.
Besides that maybe disabling the toolbutton while a command is being executed could be worthy? Or maybe is expected to be able to launch multiple installs commands at the same time? 🤔
Had to make some qss changes @dalthviz, could you check again?
You should be able to do that, also after triggering the install the lineedit will clear, si you will still need to type something and hit install again |
Fixes #84
Conda/pypi options are exclusive so selecting one, will leave that as the default.
To test locally this https://github.com/napari/napari-plugin-manager/pull/96/files#diff-c4a932d5522a5a713957223899c8991682affd18d838b197d3c508ea32333a1eR1215
might need a manual
if True