Add CI, tox config and other test adjustments

[jaimergp]

I had not imported the full history in my previous attempt. Restarting here.

Supersedes #1

[Czaki]

So if test requires dialogs then in pytest config there is a need to add new marker:
like here:
https://github.com/4DNucleome/PartSeg/blob/17eb8128e65f099536ac3edf2394b17b9b03787c/setup.cfg#L156

and decorate this test with @pytest.mark.enabledialog

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@9fe2e15). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   90.56%           
=======================================
  Files           ?        5           
  Lines           ?     1166           
  Branches        ?        0           
=======================================
  Hits            ?     1056           
  Misses          ?      110           
  Partials        ?        0           

[jaimergp]

The tests on napari_plugin_manager/_tests/test_qt_plugin_dialog.py are flaky on macOS. Sometimes they pass, but most often they don't. The error is usually:

AttributeError: 'NoneType' object has no attribute 'action_button'

with None being widget, as given by a line above:

widget = plugin_dialog_constructor.available_list.itemWidget(item)

Is this a known bug, issue or limitation? Any workarounds? It looks like it might be a race condition?

cc @goanpeca

[jaimergp]

After discussing the issue with the team on the Europe community meeting, I've added the relevant waitUntil calls to make up for the threads/scheduler timing issues.

What we are seeing now:

 >       qtbot.waitUntil(lambda: widget.available_list.count() >= 2, timeout=300)
  E       pytestqt.exceptions.TimeoutError: waitUntil timed out in 300 milliseconds
  napari_plugin_manager\_tests\test_qt_plugin_dialog.py:183: TimeoutError

This one happens in:

• Windows, Python 3.9, PySide2
• Windows, Python 3.9, PyQt5
• Windows, Python 3.10, PySide6
• macOS, Python 3.9, PyQt5

No pattern is obvious, I might just crank the timeout a bit longer?

---

  >       with qtbot.waitSignal(installer.allFinished, timeout=10000):
  E       pytestqt.exceptions.TimeoutError: Signal allFinished() not emitted after 10000 ms
  
  napari_plugin_manager\_tests\test_installer_process.py:149: TimeoutError

This one happens in:

• Windows, Python 3.10, PyQt5
• macOS, Python 3.10, PySide6

Network error?

[jaimergp]

With 1000ms of timeout, all Windows runners passed, but on macOS we observe timeouts on:

• py3.9, PyQt5
• py3.10, PyQt5
• py3.11, PyQt6

Maybe a bit more will fix it? The Python 3.10 and 3.11 errors were not present before, so I assume they are happening at random.

[jaimergp]

Ok, finally green! 🚀

[Czaki]

Did we know how many entries we expect here? If the test ends before the thread yelding new plugin entries it may end with a crash whole test setup. We should wait until this thread ends working.

[goanpeca]

Also lambdas are sometimes funky in these tests, so using a separate function might be slightly better

[jaimergp]

Done :)

[Czaki]

For reference. Bug pointed on community meeting also happens in the main repository https://github.com/napari/napari/actions/runs/4824544130/jobs/8594439707?pr=5784

[jaimergp]

For reference. Bug pointed on community meeting also happens in the main repository https://github.com/napari/napari/actions/runs/4824544130/jobs/8594439707?pr=5784

Yay not feeling alone anymore :D

[Czaki]

Two small comments/changes. Everything else looks good.

[jaimergp]

Thanks for the super helpful review @Czaki! I learnt a lot about Qt, operating systems and event loops!