Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frame capture when using PyQt6 #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix frame capture when using PyQt6 #43

wants to merge 1 commit into from

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz marked this pull request as ready for review December 16, 2024 16:22
@jni
Copy link
Member

jni commented Dec 17, 2024

@dalthviz following the references doesn't make it any clearer to me why this works. Do you have any intuition there?

@jni
Copy link
Member

jni commented Dec 17, 2024

(specifically: why does this help the Qt6 case but is unnecessary in Qt5-land?)

@Czaki
Copy link
Contributor

Czaki commented Dec 17, 2024

As I understand, it is connected with some backward compatibility code introduced by qtpy. Something like:

https://github.com/spyder-ide/qtpy/blob/1d2a1eae43bda2a3d0efef605cafc5462389ec03/qtpy/QtWidgets.py#L69-L105

@dalthviz
Copy link
Member Author

As I understand, it is connected with some backward compatibility code introduced by qtpy.

Exactly! 👍

@psobolewskiPhD
Copy link
Member

I can confirm this fixes my issue with pyqt6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Czaki approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dalthviz @jni @Czaki @psobolewskiPhD