This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Fix windows tests #143
Merged
Fix windows tests #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
reviewed
Nov 22, 2022
| @@ -6,7 +6,7 @@ toxworkdir = /tmp/.tox | |||
|
|
|||
| [testenv] | |||
| deps = pytest | |||
| pytest-cookies | |||
| git+https://github.com/hackebrot/pytest-cookies.git@refs/pull/61/head | |||
There was a problem hiding this comment.
did we want to switch to this branch globally or only for windows?
There was a problem hiding this comment.
Hmmm. Good question. I'm not sure. Maybe all tests, because it reflects the situation once--eventually--the upstream PR is merged? But I can see it either way.
nclack
approved these changes
Nov 28, 2022
|
Hmm, this PR may be even better of a fix? |
|
The other fix PR has been merged: |
|
I was released, so feel free to make such PR. I will review it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows tests are failing due to
cookiecutterissue:cookiecutter/cookiecutter#1688
This is solved with a PR to
pytest-cookiebut it's not merged (despite months of time...):hackebrot/pytest-cookies#61
So this PR uses that PR branch for
pytest-cookiesto eliminate the fails.If the PR is every merged, can go back to just
pytest-cookies