This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Fix make_sample_data return value #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just did a plugin installation via cookiecutter, but loading the sample data lead to: `TypeError: ViewerModel._add_layer_from_data() takes from 2 to 4 positional arguments but 513 were given` I checked the code here: https://github.com/napari/napari/blob/main/napari/plugins/_skimage_data.py and adapted the make_sample_data return values accordingly.
|
Are those failing tests related to my change? |
|
Looks unrelated. Also visible on |
|
@Czaki Do you think we can merge the fix or should we wait for the windows tests to pass again? |
|
thanks @mstabrin, LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just did a plugin installation via cookiecutter, but loading the sample data lead to:
TypeError: ViewerModel._add_layer_from_data() takes from 2 to 4 positional arguments but 513 were givenI checked the code here:
https://github.com/napari/napari/blob/main/napari/plugins/_skimage_data.py
and adapted the make_sample_data return values accordingly.