-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list of supported Google Pay gateways. #81
base: master
Are you sure you want to change the base?
Conversation
I had to update the list to use a different gateway, however it may be good to not call |
Are these gateways supported by default on Android? No need to setup SDKs for those addons? |
There is no need for an SDK if all you do is to get the reply (ie: For instance I use Payeezy's 3DS: {
"signature": "...",
"type": "G",
"version": "ECv1",
"data": "{\"encryptedMessage\":\"...\",\"ephemeralPublicKey\":\"...\",\"tag\":\"...\"}"
} React-Native-Payment's {
"signature": "...",
"protocolVersion": "ECv1",
"signedMessage": "{\"encryptedMessage\":\"...\",\"ephemeralPublicKey\":\"...\",\"tag\":\"...\"}"
} |
ping? |
This should be merged, otherwise there is no way to integrate almost all gateways from available list as mentioned @barbieri. |
Hey @barbieri , thanks so much for this PR, especially your follow up comments. I understand that the functionality of Google Pay is pretty different from Apple Pay and this needs a re-think. I'm maintaining this library and studying a bit, will get back to this soon. |
@kirillpisarev are you around? This was a long time ago but would like to know if this is still the right way to approach supporting gateways for Google Pay. |
@nabilfreeman i wish i could help you, but i can't remember the point of the issue and i don't have access to the source code of the project i was working on... |
As far as i remember the supported gateways could be omitted, because the list actually is pretty big and there is no reason to keep it in the code |
'payture', | ||
'stripe', | ||
'vantiv', | ||
'worldpay', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkoutltd would be great to be added
There are more gateways, not just braintree and stripe.