Allow and demonstrate NNG usage without elevated privilege #1902
Conversation
Doesn't fix nanomsg#1582 in general, rather suggests one way that demo builds could be more self contained. This commit also encourages a CMake approach for downstream clients of NNG that is gaining widespread acceptance, evidence given in the README.
|
So lets fix this to refer to the main NNG repo instead. Let me see if I can take this work and adjust it to work that way. |
|
@gdamore, after more thought, I don't like the fact that I've overloaded the meaning of
Instead of rushing to a solution, I will seek out guidance on CMake Discourse first, and come back here with an updated, more informed suggestion. |
|
@dksmiffs I'm far from a CMake expert myself. In fact, I've got plans to move away from using cmake as the "primary" build system (moving towards meson and maybe then generating the CMake from meson inputs.) I'll take a look at your concerns ... I want to think on it before I make a ruling. :-) |
@gdamore, this PR breaks two CONTRIBUTING rules, but for these reasons:
CMakeLists.txt, to refer to your repo instead of my fork.I hope you understand this awkwardness was necessary because the change I'm suggesting isn't in your repo yet, and yet my demo's
CMakeLists.txtrequires SHA1 access to the repo itself with the single line suggested change to the top-levelCMakeLists.txt.I promise I will respond to review feedback, and not leave this baby on your doorstep.