-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #1827 Windows a deadlock on nng_close() #1828
Merged
Merged
Commits on May 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4fe1b2b - Browse repository at this point
Copy the full SHA 4fe1b2bView commit details -
Another attempt at the close deadlock, fix use-after-free.
When closing pipes, we defer them to be reaped, but also leave them in the match list where they might be picked up by ep_match, or leak. It's best to reap these proactively and ensure that they are not allowed to life longer once they have errored during the negotiation phase.
Configuration menu - View commit details
-
Copy full SHA for 6d15cae - Browse repository at this point
Copy the full SHA 6d15caeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 429440a - Browse repository at this point
Copy the full SHA 429440aView commit details
Commits on May 26, 2024
-
windows: drop the hEvent initialization for win_io structures.
We use overlapped I/O, so we don't need a separate hEvent.
Configuration menu - View commit details
-
Copy full SHA for 7ad9e94 - Browse repository at this point
Copy the full SHA 7ad9e94View commit details
Commits on May 27, 2024
-
windows: fix TCP use-after-free in listener
The logic with overlapped structures was fragile as it used overlapped ios for the connections rather than a single common one for the listener. This changes it to be more like POSIX, and robust against this error.
Configuration menu - View commit details
-
Copy full SHA for afceee1 - Browse repository at this point
Copy the full SHA afceee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 153b346 - Browse repository at this point
Copy the full SHA 153b346View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d30eb2 - Browse repository at this point
Copy the full SHA 6d30eb2View commit details
Commits on May 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 76e2d45 - Browse repository at this point
Copy the full SHA 76e2d45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04c48ab - Browse repository at this point
Copy the full SHA 04c48abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57b4650 - Browse repository at this point
Copy the full SHA 57b4650View commit details -
Free SP protocol streams before discarding aio objects.
This seems to alleviate the use after free crashes, although it does not seem like it should. Current theory is that this closes the handle ensuring that it is unregistered from the I/O subsystem, thus preventing callbacks from firing and referring to objects that have been freed.
Configuration menu - View commit details
-
Copy full SHA for 9b1f8e8 - Browse repository at this point
Copy the full SHA 9b1f8e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c08f96 - Browse repository at this point
Copy the full SHA 4c08f96View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.