Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advise user if pickle requested, but pickled changes are older. #3

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

cuantar
Copy link
Collaborator

@cuantar cuantar commented Nov 29, 2022

The code is simple and has been tested as part of a toy model; but it needs someone experienced at using the timing_analysis in practice to verify that it does what is expected.

@cuantar
Copy link
Collaborator Author

cuantar commented Nov 29, 2022

I made an issue for it, so that the problem I think I'm solving can be made clear. 😄 #4

@cuantar cuantar changed the title Generate a loudly informative advisory message if pickle is requested but the pickled file is older. Advise user if pickle requested, but pickled changes are older. Nov 29, 2022
@cuantar
Copy link
Collaborator Author

cuantar commented Nov 29, 2022

don't merge this --- it does not check the *.yaml config file; needs an edit

@cuantar
Copy link
Collaborator Author

cuantar commented Nov 29, 2022

should be good now.

@cuantar cuantar self-assigned this Nov 29, 2022
@cuantar cuantar linked an issue Nov 29, 2022 that may be closed by this pull request
Copy link
Collaborator

@JPGlaser JPGlaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Default behavior is preserved with this change and just adds a small little warning on load only.

~ Joe G.

@JPGlaser
Copy link
Collaborator

I reverted this merge @cuantar . Thankful noticed several issues that appeared when the change got added. Also, we had a detailed discussion and are unsure if this is necessary, but we can iterate on it today.

JPGlaser pushed a commit that referenced this pull request Nov 1, 2024
add convert_tcb2tdb=False to all parameters, fix naming of LAMBDA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn the user if pickle is requested but the pickled file is older.
2 participants