Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-dist to latest versions #250

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Jan 15, 2024

Description

  • paths-ignore is not valid for workflow-dispatch
  • Use latest actions and node version 18

Motivation and Context

  • Maintainability
  • Node 16 is deprecated (if not already removed).

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Use latest actions and lts node version
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@networkfusion networkfusion merged commit f32bdf0 into develop-update-packages Jan 16, 2024
3 checks passed
@networkfusion networkfusion deleted the test-chk-dist branch January 16, 2024 00:25
@networkfusion networkfusion restored the test-chk-dist branch January 16, 2024 00:26
@josesimoes josesimoes changed the title Update check-dist.yml Update check-dist to latest versions Jan 16, 2024
@josesimoes josesimoes deleted the test-chk-dist branch January 16, 2024 00:27
@networkfusion networkfusion restored the test-chk-dist branch January 16, 2024 00:33
@networkfusion networkfusion deleted the test-chk-dist branch January 16, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants