Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up System.IO.File and adding additional methods #89

Merged
merged 15 commits into from
Nov 8, 2023
Merged

Cleaning up System.IO.File and adding additional methods #89

merged 15 commits into from
Nov 8, 2023

Conversation

CoryCharlton
Copy link
Member

Description

  • Refactored existing code to ensure intellisense is correct and expected behavior is implemented
  • Added unit tests to cover the existing methods
  • Added several helper methods for opening, reading, and writing files.

Motivation and Context

  • Implement missing functionality from .NET Full and simply common tasks

How Has This Been Tested?

  • On device
  • Unit tests

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!! Nice. A few comments and tiny things, but overall pretty good.
Thanks for the improvements. 😃 👍🏻

System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more...

System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
System.IO.FileSystem/File.cs Outdated Show resolved Hide resolved
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you. 👍🏻

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes merged commit 88d8198 into nanoframework:main Nov 8, 2023
5 checks passed
@CoryCharlton CoryCharlton deleted the improving_file branch November 8, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: enhancement New feature or request Type: Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants