Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in GpioPin #7

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Improvements in GpioPin #7

merged 1 commit into from
Oct 22, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Code simplification by moving reponsabilities to the native code.
  • Simplified access to SetPinMode when opening a pin from GpioController.
  • Minor fixes in code style.
  • Improve comments for documentation.
  • Bump AssemblyNativeVersion to 100.1.0.3.

Motivation and Context

How Has This Been Tested?

  • Blinky sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Improvements in GpioPin
5c8bd8a 
- Code simplification by moving reponsabilities to the native code.
- Simplified access to SetPinMode when opening a pin from GpioController.
- Minor fixes in code style.
- Improve comments for documentation.
- Bump AssemblyNativeVersion to 100.1.0.3.
@nfbot
Copy link
Member

nfbot commented Oct 22, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot nfbot added Type: bug Something isn't working Type: enhancement New feature or request labels Oct 22, 2020
@josesimoes josesimoes mentioned this pull request Oct 22, 2020
Merged
12 tasks
@josesimoes josesimoes merged commit e46099c into nanoframework:develop Oct 22, 2020
@josesimoes josesimoes deleted the improvements-gpiopin branch October 22, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: bug Something isn't working Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when accessing writing to Gpio with System.Device.Gpio
2 participants
@josesimoes @nfbot