Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename namespace from Devices to Device #24

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Aug 3, 2020

Description

Renames the namespace from System.Devices to System.Device
(will require the repo to be renamed.

Motivation and Context

Follows latest preview .net 5 namespace as found at https://github.com/dotnet/iot/tree/master/src/System.Device.Gpio/System/Device

How Has This Been Tested?

No tests run yet.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

follows latest preview .net 5 namespace
@nfbot
Copy link
Member

nfbot commented Aug 3, 2020

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot nfbot added Type: enhancement New feature or request Breaking-Change labels Aug 3, 2020
@CLAassistant
Copy link

CLAassistant commented Aug 3, 2020

CLA assistant check
All committers have signed the CLA.

@josesimoes josesimoes merged commit 92722a2 into develop Aug 6, 2020
@josesimoes josesimoes deleted the develop-namespace branch September 10, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants