Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating namespaces for nanoFramework.DependencyInjection #332

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Updating namespaces for nanoFramework.DependencyInjection #332

merged 2 commits into from
Nov 8, 2023

Conversation

CoryCharlton
Copy link
Member

@CoryCharlton CoryCharlton commented Nov 4, 2023 •
edited by josesimoes
Loading

Description

Updating namespaces for nanoframework/nanoFramework.DependencyInjection#33

Motivation and Context

These changes are required once the PR is merged.

How Has This Been Tested?

It compiles.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a sample)
  • Bug fix (fixes an issue with a current sample)
  • New Sample (adds a new sample)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: bug label Nov 4, 2023
@CoryCharlton
Copy link
Member Author

I'll update this PR once nanoframework/nanoFramework.DependencyInjection#33 is merged.

@CoryCharlton
Copy link
Member Author

A quick check shows there are still changes required in the following paths:

  • nanoFramework.Samples\samples\Hosting
  • nanoFramework.Samples\samples\Webserver\WebServer.DI

I'll do a more comprehensive check and complete all these changes once the DI PR is merged.

@CoryCharlton CoryCharlton mentioned this pull request Nov 4, 2023
Merged
14 tasks
@CoryCharlton CoryCharlton changed the title Updating namespaces for #nanoframework/nanoFramework.DependencyInjection/pull/33 Updating namespaces for nanoFramework.DependencyInjection Nov 4, 2023
@CoryCharlton
Copy link
Member Author

Believe this covers all the samples that reference nanoFramework.DependencyInjection

josesimoes
josesimoes approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for updating these. 👍🏻

@josesimoes josesimoes merged commit 1559560 into nanoframework:main Nov 8, 2023
2 checks passed
@CoryCharlton CoryCharlton deleted the fix_di_namespace branch November 8, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CoryCharlton @josesimoes @nfbot