Remove unchecked_info::account and unchecked_info::verified #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original purpose of this code was a performance improvement to eliminate the need to check signatures multiple times while bootstrapping. Improvements to the bootstrap client and block processor pipeline will make this performance improvement negligible and not worth the complexity.
…er part of the signature checking optimization that's being removed. With state blocks the account can be queried directly from the block.
simpago
added a commit
to rsnano-node/rsnano-node
that referenced
this pull request
Feb 15, 2023
In pull request nanocurrency#4021 the binary representation of `unchecked_info` was changed. We have to clear the unchecked table, because the new binary format is not compatible with the old one.
simpago
added a commit
to rsnano-node/rsnano-node
that referenced
this pull request
Feb 15, 2023
In pull request nanocurrency#4021 the binary representation of `unchecked_info` was changed. We have to clear the unchecked table, because the new binary format is not compatible with the old one. This commit only clears the unchecked table for the LMDB implementation. The RocksDB implementation doesn't have an upgrade mechanism yet.
simpago
added a commit
to rsnano-node/rsnano-node
that referenced
this pull request
Feb 15, 2023
In pull request nanocurrency#4021 the binary representation of `unchecked_info` was changed. We have to clear the unchecked table, because the new binary format is not compatible with the old one. This commit only clears the unchecked table for the LMDB implementation. The RocksDB implementation doesn't have an upgrade mechanism yet.
thsfs
reviewed
Mar 1, 2023
thsfs
pushed a commit
to rsnano-node/rsnano-node
that referenced
this pull request
Apr 25, 2023
In pull request nanocurrency#4021 the binary representation of `unchecked_info` was changed. We have to clear the unchecked table, because the new binary format is not compatible with the old one. This commit only clears the unchecked table for the LMDB implementation. The RocksDB implementation doesn't have an upgrade mechanism yet.
thsfs
pushed a commit
to rsnano-node/rsnano-node
that referenced
this pull request
May 4, 2023
In pull request nanocurrency#4021 the binary representation of `unchecked_info` was changed. We have to clear the unchecked table, because the new binary format is not compatible with the old one. This commit only clears the unchecked table for the LMDB implementation. The RocksDB implementation doesn't have an upgrade mechanism yet. - Delete the unchecked DB from the LMDB environment - Simplify the unchecked handle
thsfs
added
routine
clemahieu
added a commit
to clemahieu/nano-node
that referenced
this pull request
Nov 6, 2023
…or::blocks regardless of type. Negative testing for signatures of state/epoch blocks is done with ledger.fail_state_bad_signature and ledger.fail_epoch_bad_signature. Signature checking is always done within the block verification functions themselves since nanocurrency#4021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two fields in unchecked_info related to an optimisation that will not be relevant when the ascending bootstrap client is used and with the block processor pipeline improvements.
This reduces complexity around signature checking code and reduces the amount of data tracked for unchecked entries.