Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development #75

Merged
merged 8 commits into from
Dec 5, 2020
Merged

Development #75

merged 8 commits into from
Dec 5, 2020

Conversation

madeyoga
Copy link
Member

@madeyoga madeyoga commented Dec 5, 2020 •
edited
Loading

Feature updates

  • Improves memory usage
  • Improves command restrictions. Only member that connected to the Musicfy's voice channel can use/call Music commands.
  • Member (That is not connected to Musicfy's voice channel) no longer can use leave command. (Leave Command from outside client's voice)

Core updates

  • Removes standard output from MemberVoiceListener
  • Added slf4j logger to MusicService
  • Added MusicService.ensureVoiceState
  • Implements the new ensure voice method to all music commands
  • MusicService.joinUserVoiceChannel now returns the joined voice channel instead of boolean.
  • Catch and logs MysqlDataTruncation exception

@madeyoga madeyoga added the enhancement New feature or request label Dec 5, 2020
@madeyoga madeyoga self-assigned this Dec 5, 2020
@madeyoga madeyoga added the bug Something isn't working label Dec 5, 2020
@madeyoga madeyoga merged commit 4441a05 into master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madeyoga madeyoga

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madeyoga