-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make nannou package compile in WASM environment #715
Conversation
Nice to see a start on this! One thing that might be worth adding while landing wasm support would be one new CI job that tries to build one or more of the examples for the wasm target, or something along these lines. Normally I would say CI testing of specific platforms is best left for the cross platform crates like winit and cpal. However in our case I think it might be easy for us to accidentally break wasm compatibility otherwise, particularly as some library APIs just aren't compatible with wasm (like those wgpu items you had to gate in this PR) and it's not always obvious what those are. |
Sorry I haven't responded yet. I will rebase this PR and see how to adapt the CI job once #737 is merged. |
5ac41b2
to
68dc2b4
Compare
@mitchmindtree I upgraded this PR to the newest Nannou version and added a CI check. |
@mitchmindtree Currently, it's not possible to compile the whole Nannou tree to WASM. |
Other problematic libraries that need to be removed or hidden behind a feature switch are |
68dc2b4
to
753a038
Compare
@mitchmindtree The PR has been updated to the newest Nannou release. I propose to merge the PR s.t. the main |
Hi. This is a minimal example showing which changes will allow to compile the nannou module against the
wasm32-unknown-unknown
target.Disclaimer: I am not saying that:
This PR relates to #475.