Linear gradient

[cmaycumber]

Adds a linear gradient component to solve: #73

[nandorojo]

I'm thinking we should move the gradient into its own package so that people who aren't using it don't need to install the extra dependency. This is what I did for Moti's skeleton.

[cmaycumber]

I'm thinking we should move the gradient into its own package so that people who aren't using it don't need to install the extra dependency. This is what I did for Moti's skeleton.

Everything should be in the gradient package. Let me know if I missed something or maybe accidentally exported it from core. I'll take a look through it again later today.

[nandorojo]

Looks like it's exported in the main Dripsy package, but it should require installing @dripsy/gradient

[cmaycumber]

Ahh I gotcha I'll make the change

[nandorojo]

Also, the dependency for Dripsy/core should have a specified version instead of *

[nandorojo]

We should probably change this to use expo-module prepare for the build step too, although I want to see what's up with #86. We might need a custom webpack config for web apps, like this one from moti: https://moti.fyi/web

[cmaycumber]

We should probably change this to use expo-module prepare for the build step too, although I want to see what's up with #86. We might need a custom webpack config for web apps, like this one from moti: https://moti.fyi/web

Do you think we should add this before merging in or do you still want to experiment a bit more with how expo-module's is affecting the web projects?

[nandorojo]

We can leave it with Bob for now to keep comparing, even though the expo module scripts is merged to master in the other packages.

[nandorojo]

This should come from the unique package btw

[nandorojo]

Made some changes, last thing is so fix the merge conflicts and update the example

[nandorojo]

https://theme-ui.com/migrating/ migration guide here

[nandorojo]

Seems like the biggest breaking change to deal with is the fact that emotion upgrades from 10 -> 11. Besides that, it's the JSX pragma syntax, and then some small stuff.

[cmaycumber]

https://theme-ui.com/migrating/ migration guide here

Sweet this should be helpful. I'll take a look at this tonight.

[nandorojo]

One seemingly large breaking change is that the colors in the useThemeUI hook has changed to rawColors... 😬

I assume this is due to CSS variables? I'm not sure. Maybe we can just override that by reassigning rawColors: colors to start.

[nandorojo]

Sorry not sure why I put those theme-ui notes on this PR. Got it mixed up.

[nandorojo]

This PR is good to go, just need to fix the import in the example, make sure the gradient is not exported by the main package, and fix the remaining merge conflicts that GitHub is upset about.

[cmaycumber]

This PR is good to go, just need to fix the import in the example, make sure the gradient is not exported by the main package, and fix the remaining merge conflicts that GitHub is upset about.

Will do.

[cmaycumber]

@nandorojo This should be gtg. Let me know.

[nandorojo]

Cool thanks. Thoughts on exporting it as a named variable rather than default from dripsy/gradient?

[cmaycumber]

Cool thanks. Thoughts on exporting it as a named variable rather than default from dripsy/gradient?

I'd prefer that. I think that will help keep things consistent.

[cmaycumber]

Do you have a preference over just Gradient or LinearGradient?

[nandorojo]

Was just thinking that.

LinearGradient is more clear, since that's what it does (no radial, etc). Also consistent with the expo naming. It also sounds lamer, though.

I prefer Gradient. I'll sit on it for a few minutes but I say let's go with that. Sounds cleaner.

[cmaycumber]

I prefer Gradient. I'll sit on it for a few minutes but I say let's go with that. Sounds cleaner.

Cool, I agree and it's nice that it's the name as the package name.

[nandorojo]

Let's stick with that

[nandorojo]

Pointing this to the v2 branch