Breaks up dripsy into @dripsy/core and dripsy #74
Conversation
|
I think this looks good to me. Will publish it to be sure. |
|
I think this is all good. One thing: could you remove peer dependencies from core? I think we should move these to dev dependencies now, especially with NPM's recent changes. |
|
|
Yes for sure! Curious about the NPM changes. I haven't caught wind of them yet. What impact do they have? |
|
I saw Brent from expo tweeting about some major behavior changes of them auto installing or something like that. Also, in general, I think they throw unnecessary warnings in the console too. Everyone using Dripsy has React Native installed, no need to bug them about it. |
|
Cool, totally agree. Thanks for the insight. |
|
No prob. Lmk if you're able to test that publish in your app smoothly |
|
I think it's working well for me, will continue to test tomorrow and publish if it works for you! |
|
Everything looks good on my end. |
|
Sorry for the delay here, been really busy but looking forward to getting it merged shortly. |
|
Let me know when you get the change to remove the peer deps and we'll get this out |
Sweet should be able to do this pretty soon. |
packages/dripsy/package.json
Outdated
| "@theme-ui/css": "^0.4.0-rc.1", | ||
| "hoist-non-react-statics": "^3.3.2", | ||
| "theme-ui": "^0.4.0-rc.3" | ||
| "@dripsy/core": "*" |
There was a problem hiding this comment.
@cmaycumber what's best practice for this? I'm unaware. Does the * just allow any version? Presumably we'd want the versions to match up. I saw lerna has an exact option, not sure if that's what we want or not.
There was a problem hiding this comment.
Possibly related: lerna/lerna#359
There was a problem hiding this comment.
Since lerna publish will make all the version increment, I wonder if there's a way to make them also increment in the respective package.json files.
There was a problem hiding this comment.
I notice here that they use exact versions: https://github.com/system-ui/theme-ui/blob/ca00080aa3ceee704ad1fc4de99ada044e9b9193/packages/theme-ui/package.json#L22
I'm also wondering what the answer is for moti's sake.
There was a problem hiding this comment.
@cmaycumber what's best practice for this? I'm unaware. Does the * just allow any version? Presumably we'd want the versions to match up. I saw lerna has an
exactoption, not sure if that's what we want or not.
Yeah, it's just the latest. I've looked around for something that manages exact versions in a monorepo and haven't been able to find anything that locks versions/updates them across packages.
We can switch to the exact versions I'm curious if there's a "best practice" solution for incrementing the versions or if we'll just have to write a script.
There was a problem hiding this comment.
So it looks like lerna does this for you if you use semver versioning ^0.x.y. I added versions like that in Moti, and when I ran lerna publish, it incremented all the dependencies for me.
|
yup! last thing i'd say is to add the version for the internal dripsy dependencies so that lerna can handle incrementing those. |
|
Got it. I'll add that in. So does Lerna automatically bump the dependencies? Edit: Nvm read the comment above. |
|
I think it might be because I added this to Moti. |
|
Let me know if the ch ages to the lerna file look correct. |
|
|
|
For some reason, running |
|
Okay I got this in my app. The good news, seems like it gets rid of |
|
We'll need to add release notes for this (call it |
|
This took me a bit to complete since it required refactoring 100+ files in my real app while we're shipping many features. But finally, it's merged! Published with |
All good! Thanks for this. I'll try to rip out some of my other PR's. |
This pull request modularizes the dripsy monorepo into @dripsy/core and dripsy. Doing this will help us add packages in the future that rely upon additional dependencies.
This PR also has changes that reduce the bundle size by not including the entire
theme-uipackage which wasn't being used and now relies solely on@theme-ui/core.