Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Accept XLSX files for input #297

Merged
merged 9 commits into from
Sep 6, 2023
Merged

feat: Accept XLSX files for input #297

merged 9 commits into from
Sep 6, 2023

Conversation

nandenjin
Copy link
Owner

@nandenjin nandenjin commented Sep 4, 2023

Fixes #2
Accept XLSX format for input due to inconsistency of CSV formatted data.

@nandenjin nandenjin added this to the for-v1 milestone Sep 4, 2023
@nandenjin nandenjin self-assigned this Sep 4, 2023
@nandenjin nandenjin linked an issue Sep 4, 2023 that may be closed by this pull request
@nandenjin nandenjin linked an issue Sep 4, 2023 that may be closed by this pull request
fix: Support column shift
"updatedAt" is now at column "S" (`r[18]`)
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #297 (819999d) into for-v1 (b077fa5) will increase coverage by 0.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           for-v1     #297      +/-   ##
==========================================
+ Coverage   97.12%   97.85%   +0.73%     
==========================================
  Files           3        3              
  Lines         139      140       +1     
  Branches       23       23              
==========================================
+ Hits          135      137       +2     
+ Misses          3        2       -1     
  Partials        1        1              
Files Changed Coverage Δ
src/index.ts 96.42% <100.00%> (+1.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nandenjin nandenjin merged commit e740cbb into for-v1 Sep 6, 2023
4 checks passed
@nandenjin nandenjin deleted the refactor-use-xlsx branch September 6, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding conversion failure
1 participant