Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use playwright integrate #49

Open
wants to merge 3 commits into
base: 4.1
Choose a base branch
from
Open

Use playwright integrate #49

wants to merge 3 commits into from

Conversation

nanasess
Copy link
Owner

概要(Overview・Refs Issue)

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更はありません
  • フックポイントの呼び出しタイミングの変更はありません
  • フックポイントのパラメータの削除・データ型の変更はありません
  • twigファイルに渡しているパラメータの削除・データ型の変更はありません
  • Serviceクラスの公開関数の、引数の削除・データ型の変更はありません
  • 入出力ファイル(CSVなど)のフォーマット変更はありません

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@nanasess nanasess force-pushed the use-playwright-integrate branch from 8a9327b to 920aa59 Compare December 21, 2021 08:10
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #49 (25ba274) into 4.1 (ae8cbf2) will increase coverage by 0.09%.
The diff coverage is 78.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.1      #49      +/-   ##
============================================
+ Coverage     68.35%   68.44%   +0.09%     
- Complexity        0     6121    +6121     
============================================
  Files           456      461       +5     
  Lines         24945    25166     +221     
============================================
+ Hits          17052    17226     +174     
- Misses         7893     7940      +47     
Flag Coverage Δ
E2E 56.73% <13.24%> (?)
Unit 76.20% <85.94%> (?)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Eccube/Controller/Admin/Order/MailController.php 46.87% <ø> (-1.80%) ⬇️
...Eccube/DependencyInjection/Facade/LoggerFacade.php 76.92% <0.00%> (ø)
src/Eccube/Service/OrderHelper.php 87.30% <ø> (-0.07%) ⬇️
src/Eccube/Form/Type/Admin/SearchProductType.php 58.33% <26.66%> (-3.64%) ⬇️
src/Eccube/Controller/SitemapController.php 79.48% <40.00%> (-4.30%) ⬇️
src/Eccube/Entity/Cart.php 68.67% <66.66%> (+0.77%) ⬆️
src/Eccube/Form/Type/Admin/CalendarType.php 67.34% <67.34%> (ø)
src/Eccube/Repository/CalendarRepository.php 71.87% <71.87%> (ø)
src/Eccube/Entity/Calendar.php 76.00% <76.00%> (ø)
...ntroller/Admin/Setting/Shop/CalendarController.php 87.50% <87.50%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7b8a7...25ba274. Read the comment docs.

@nanasess nanasess force-pushed the use-playwright-integrate branch 3 times, most recently from 0fd9a80 to e7789a2 Compare December 21, 2021 13:34
@nanasess nanasess force-pushed the use-playwright-integrate branch from e7789a2 to f157ab7 Compare December 21, 2021 15:45
@nanasess nanasess force-pushed the 4.1 branch 4 times, most recently from 1c99cab to c3b5152 Compare October 27, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant