Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Reports #70

Closed
5 tasks done
NikunjKhangwal opened this issue Nov 28, 2023 · 9 comments
Closed
5 tasks done

Bug Reports #70

NikunjKhangwal opened this issue Nov 28, 2023 · 9 comments

Comments

@NikunjKhangwal
Copy link

NikunjKhangwal commented Nov 28, 2023

  • 1. There was a bug where instead of showing synced lyrics normally the app was showing lyrics in plain format with their timestamps before lines. Also they become left aligned instead of center. Refreshing the library fixed it. Sorry, i forgot to take the screenshot of this.

  • 2. Backups aren't being created in my specified folder. They're still going to Internal Storage/Namida/Backups

  • 3. Not sure if this is on purpose but "Use Collapsed Setting Tiles" option exist in both the main Settings page and under Extras

  • 4. The app doesn't show Disc Number for songs even after re-indexing. (Musicolet screenshot on right for reference)
    photo_2_2023-11-28_19-47-09

  • 5. Searching a song by artist name doesn't show the results
    photo_3_2023-11-28_19-47-09

@NikunjKhangwal
Copy link
Author

Just wanted to mention the screenshot i attached isn't showing youtube link in comment either, this was before i re-indexed my library. This is not a bug, only disc number is.

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 28, 2023

thank u a lot for the awesome detailed report <3

  1. this means that the parser failed to identify it as a lrc file and thus using it as a text, refreshing ur library may caused to use another source for the lyrics (embedded maybe)
  2. ops gonna check, i may forgor to use user specified path tehe
  3. yeah it's on purpose, for easier access.. the option itself was useful at first but now that most of the section have grown bigger, im thinking about removing it
    • what about other tags like album and artist? to me, the file appears sussy, even the modified date couldn't be extracted.
    • are u using media store btw? i don't think it has such info always
    • the info dialog doesn't extract any info in real time, u may check real time info by choosing "edit tags", the result of this will help identify the cause
    • if "edit tags" still has the same issue, and it happens only with some tracks, u may send me a sample or smth to check
  4. weird, u sure u have "artist" enabled in "track search filters" in "extra settings"?
  5. it's not a bug but a feature request, i have thought about this but i can't find any source i could rely on. basically what we need here is something like a dictionary to convert this type of characters to the English ones (for example à => a), if u can provide any source then it will be easy

MSOB7YY added a commit that referenced this issue Nov 28, 2023
@NikunjKhangwal
Copy link
Author

  1. Yes the song did had embedded lyrics. The lrc file was working fine before, it kinda happened for once.
  2. Strange since Musicolet was showing it. I guess I'll test other tracks and then give update about it. I'm not using media store.
  3. Dang it, my dumbass probably messed around with this setting at some point and forgot.
  4. Not yet, I'll inform if i find one.

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 29, 2023

so point 1, 3, 5 are no longer an issue right? point 2 was fixed in an earlier commit as mentioned

so only 4 & 6 are left now, im gonna update the list, correct me if im wrong

@NikunjKhangwal
Copy link
Author

Yes, update it.

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 5, 2023

@NikunjKhangwal
can you please confirm the status of issue 4 after latest release v1.8.5? (disc number issue)

also open a separate issue for number 6, as its a feature request not a bug

@NikunjKhangwal
Copy link
Author

Nope. Musicolet still does. I'm sharing these files so you can further investigate.

@MSOB7YY
Copy link
Member

MSOB7YY commented Jan 10, 2024

@NikunjKhangwal i don't know how i overlooked this lmao but this definitely not an issue with tags extracting
i examined the 2 tracks u sent and confirmed they both don't have disc number tag

  • results from AutoTagger (uses jaudiotagger like namida)
    Screenshot_20240110-204522_AutoTagger
  • results from ffmpeg
    Screenshot_20240110-204722_FFmpeg_Media_Encoder
    (notice both dont have disc number tag)

what musicolet does is simply showing 1 if disc number was missing, im not an expert at these so should it be really 1?

going to close since its not really a bug, just let me know about the fallback disc number thingy, although i do believe it should be left unknown, to indicate that there wasn't any disc number set to this track

@MSOB7YY MSOB7YY closed this as completed Jan 10, 2024
@NikunjKhangwal
Copy link
Author

Good to know it's not a problem with Namida itself. Yes, the fallback disc number should be unknown. Showing number creates confusion which happened in this case lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants