Remove maxdepth policy for Go #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehran-prs
changed the title
mehran-prs
changed the title
mehran-prs
changed the title
|
Can anyone help to review this PR? Or @mhamrah could you please review this? Thank you so much. |
|
I'm not a member of this project anymore. I created grpckit as a (imo)
better replacement and suggest you use that for declarative generation and
plugin extensability:
https://medium.com/@mhamrah/introducing-grpckit-and-omniproto-a-toolchain-for-your-grpc-needs-9a92bd358bf1
…On Wed, Jul 29, 2020, 2:42 AM William Luo ***@***.***> wrote:
Can anyone help to review this PR? Or @mhamrah
<https://github.com/mhamrah> could you please review this? Thank you so
much.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWIGSBSNJNQUN23S46T73R57AEJANCNFSM4LXIGE7A>
.
|
|
Hi @toyota790, unless you've decided to move to grpckit (Hi @mhamrah :)), |
|
BTW looks like this should be safe to do thanks to golang/protobuf#39 (comment) |
|
superseded by #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you see PR #61 please?
I removed maxdepth that is
1for Golang.