Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly describe RatingLoadingIcon size when rendering it #276

Merged
merged 1 commit into from
May 24, 2024

Conversation

FrancoAguzzi
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples.nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 3:01pm
nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 3:01pm
storybook.namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 3:01pm

Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 3b980cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi Changes here look good. Can you please prepare a changeset as part of this PR? This can be a nice practice opportunity for us.

@FrancoAguzzi
Copy link
Collaborator Author

@lightwalker-eth I'd love to but I can't! 😃⬇️

Changeset is not tied to the apps/ folder, but it is to packages/ folder

In this PR I only changed one file from within apps/examples.nameguard.io which means no Changeset files can be generated for later version bump!

Image below reflects what we see in terminal after a pnpm changeset call:
Captura de Tela 2024-05-23 às 11 28 36

Indeed I want to practice Changeset usage!

No doubts I will soon be able to do it in some of our PRs 🚀🙌🏼

Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi You're right! Thanks for your good comment. Reviewed and approved 👍

@lightwalker-eth lightwalker-eth merged commit 1a8665c into main May 24, 2024
9 checks passed
@lightwalker-eth lightwalker-eth deleted the chore/improve-component-usage-description branch May 24, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants