chore: refactor react components to use Rating #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancoAguzzi
requested review from
djstrong,
Carbon225,
notrab,
Byczong and
lightwalker-eth
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lightwalker-eth
requested changes
Apr 28, 2024
There was a problem hiding this comment.
@FrancoAguzzi Thanks for your updates. Reviewed and shared feedback 👍
packages/nameguard-react/src/components/icons/LoadingShield.tsx
Outdated
Show resolved
Hide resolved
examples/with-nextjs/src/app/components/ImpersonationShield.tsx
Outdated
Show resolved
Hide resolved
lightwalker-eth
requested changes
Apr 30, 2024
There was a problem hiding this comment.
@FrancoAguzzi Thanks for your updates. Reviewed and shared feedback 👍
lightwalker-eth
requested changes
May 1, 2024
There was a problem hiding this comment.
@FrancoAguzzi Many great improvements here. 🙌 Reviewed and shared feedback 👍
lightwalker-eth
requested changes
May 6, 2024
There was a problem hiding this comment.
@FrancoAguzzi Hey, many great updates here. Still more for us to improve. Reviewed and shared feedback.
refine icon naming standards
lightwalker-eth
requested changes
May 7, 2024
There was a problem hiding this comment.
@FrancoAguzzi Hey some really super updates here. Nice work! I've completed another detailed review and shared additional suggestions for feedback 👍
packages/nameguard-react/src/components/Search/SearchEmptyState.tsx
Outdated
Show resolved
Hide resolved
packages/nameguard-react/src/components/Report/CheckResultCard.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: lightwalker.eth <[email protected]>
Co-authored-by: lightwalker.eth <[email protected]>
Remove VSCode error about vitest v1.3.1 not supported
Refine big merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.