Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace types usage by enums #247

Merged

Conversation

FrancoAguzzi
Copy link
Collaborator

No description provided.

Copy link

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nameguard-website ❌ Failed (Inspect) Apr 4, 2024 7:15pm

Copy link
Member

@notrab notrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the changes to the version in package.json for nameguard/react, this looks good to me. It meets the goals we discussed in Slack for using enums instead of types so we can remove the logic in namehash/kit.

@FrancoAguzzi FrancoAguzzi merged commit 44de6c4 into main Apr 4, 2024
3 of 7 checks passed
@FrancoAguzzi FrancoAguzzi deleted the francoaguzzi/sc-24705/export-enums-from-nameguard branch April 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants