Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SC-23150] ENS Webfont package creation #219

Merged
merged 15 commits into from
Feb 5, 2024
Merged

feat: [SC-23150] ENS Webfont package creation #219

merged 15 commits into from
Feb 5, 2024

Conversation

FrancoAguzzi
Copy link
Collaborator

… ENS Name config

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #23150: Fix font configuration in NameGuard app.

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nameguard-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 3:22pm

notrab
notrab reviewed Jan 25, 2024
View reviewed changes
packages/fonts/package.json Outdated Show resolved Hide resolved
lightwalker-eth
lightwalker-eth requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this new package coming together 👍 Shared a few comments with feedback

packages/fonts/package.json Outdated Show resolved Hide resolved
packages/fonts/package.json Outdated Show resolved Hide resolved
notrab
notrab reviewed Jan 27, 2024
View reviewed changes
packages/fonts/package.json Outdated Show resolved Hide resolved
lightwalker-eth
lightwalker-eth reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the collaborative improvements here 👍

lightwalker-eth
lightwalker-eth requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi great to see these updates. We're getting closer.

Please check the comments added by @notrab and me. Please also have a look at the preview environment. Currently a lot of things are broken for me. Perhaps this is related to the comment shared in code review about not applying this class everywhere across the app?

Appreciate your advice.

apps/website/src/app/layout.tsx Outdated Show resolved Hide resolved
apps/website/src/app/layout.tsx Outdated Show resolved Hide resolved
packages/nameguard-react/src/components/Report/LoadingSkeleton.tsx Show resolved Hide resolved
packages/ens-webfont/README.md Show resolved Hide resolved
packages/ens-webfont/README.md Outdated Show resolved Hide resolved
@FrancoAguzzi FrancoAguzzi changed the title feat: [SC-23150] Created needed files to be exported for a configured… feat: [SC-23150] ENS Webfont package creation Feb 4, 2024
FrancoAguzzi
FrancoAguzzi commented Feb 4, 2024
View reviewed changes
Copy link
Collaborator Author

@FrancoAguzzi FrancoAguzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey gentleman!

I've done enhancements to our NPM package, you can find these in this loom video

I hope you like it! Open to suggestions ;)

Thanks!

lightwalker-eth
lightwalker-eth reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi exciting to see the updates you've made.

@notrab @djstrong Could you guys please have a look over this PR and let us know if this looks ok to you to approve for merge? Appreciate your help getting this PR closed successfully.

apps/website/src/app/globals.css Show resolved Hide resolved
packages/nameguard-react/src/components/Report/LoadingSkeleton.tsx Show resolved Hide resolved
lightwalker-eth
lightwalker-eth approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Happy to launch this! 🚀

@FrancoAguzzi FrancoAguzzi merged commit 1372f8c into main Feb 5, 2024
7 checks passed
@FrancoAguzzi FrancoAguzzi deleted the francoaguzzi/sc-23150/export-ens-name-font-config branch February 5, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightwalker-eth lightwalker-eth lightwalker-eth approved these changes

@djstrong djstrong djstrong approved these changes

@notrab notrab notrab approved these changes

@Carbon225 Carbon225 Awaiting requested review from Carbon225 Carbon225 is a code owner

@Byczong Byczong Awaiting requested review from Byczong

@kamilcieslak5100 kamilcieslak5100 Awaiting requested review from kamilcieslak5100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrancoAguzzi @notrab @djstrong @lightwalker-eth