Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic check titles proposals #171

Merged
merged 7 commits into from
Nov 30, 2023
Merged

dynamic check titles proposals #171

merged 7 commits into from
Nov 30, 2023

Conversation

djstrong
Copy link
Collaborator

No description provided.

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #22908: Dynamic check titles.

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nameguard-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 0:14am

lightwalker-eth
lightwalker-eth requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it was helpful ! Shared suggestions

api/nameguard/checks/dna/normalized.py Outdated Show resolved Hide resolved
api/nameguard/checks/grapheme/confusables.py Outdated Show resolved Hide resolved
api/nameguard/checks/grapheme/font_support.py Outdated Show resolved Hide resolved
api/nameguard/checks/grapheme/font_support.py Outdated Show resolved Hide resolved
api/nameguard/checks/grapheme/font_support.py Outdated Show resolved Hide resolved
api/nameguard/checks/name/punycode_name.py Outdated Show resolved Hide resolved
api/nameguard/checks/dna/normalized.py Outdated Show resolved Hide resolved
api/nameguard/checks/dna/normalized.py Outdated Show resolved Hide resolved
api/nameguard/checks/grapheme/confusables.py Outdated Show resolved Hide resolved
api/nameguard/checks/grapheme/confusables.py Outdated Show resolved Hide resolved
lightwalker-eth
lightwalker-eth approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates. Approved with the open questions in Slack

api/nameguard/checks/label/punycode.py Outdated Show resolved Hide resolved
lightwalker-eth
lightwalker-eth approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks let's try this !

@djstrong djstrong merged commit f3825b8 into main Nov 30, 2023
5 checks passed
@djstrong djstrong deleted the krzysztofwrobel/sc-22908/dynamic-check-titles branch November 30, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightwalker-eth lightwalker-eth lightwalker-eth approved these changes

@Carbon225 Carbon225 Awaiting requested review from Carbon225 Carbon225 is a code owner

@notrab notrab Awaiting requested review from notrab notrab is a code owner

@Byczong Byczong Awaiting requested review from Byczong

@kamilcieslak5100 kamilcieslak5100 Awaiting requested review from kamilcieslak5100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djstrong @lightwalker-eth