feat(nameguard-react): canonical badge #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notrab
requested review from
djstrong,
Carbon225,
Byczong,
kamilcieslak5100 and
lightwalker-eth
as code owners
|
This pull request has been linked to Shortcut Story #22894: Implement canonical badge in NameGuard. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
notrab
commented
Nov 29, 2023
packages/nameguard-react/src/components/GraphemeModal/ConfusableListItem.tsx
Outdated
Show resolved
Hide resolved
lightwalker-eth
approved these changes
Nov 29, 2023
packages/nameguard-react/src/components/GraphemeModal/ConfusableListItem.tsx
Outdated
Show resolved
Hide resolved
lightwalker-eth
approved these changes
Nov 30, 2023
notrab
deleted the
notrab/sc-22894/implement-canonical-badge-in-nameguard
branch
djstrong
requested changes
Nov 30, 2023
| /** | ||
| * The canonical status for the current grapheme. | ||
| * */ | ||
| is_canonical: boolean; |
There was a problem hiding this comment.
Is_canoncial is not in ConsolidatedGraphemeGuardReport, we need new type: ConfusableGuardReport extends ConsolidatedGraphemeGuardReport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.