feat(nameguard-react): share modal #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notrab
requested review from
djstrong,
Carbon225,
Byczong,
kamilcieslak5100 and
lightwalker-eth
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lightwalker-eth
requested changes
Nov 27, 2023
| return `mailto:?subject=${subjectEncoded}&body=${bodyEncoded}`; | ||
| } | ||
|
|
||
| export function Share({ name }: ShareProps) { |
There was a problem hiding this comment.
On my iPhone when I first open the share model it opens as shown below (you might need to scroll for the big screenshot). We should make sure that the modal opens to immediately show all the share buttons at the bottom.
There was a problem hiding this comment.
@lightwalker-eth I changed this to appear the same as other modals for now.
Co-authored-by: lightwalker.eth <[email protected]>
notrab
changed the title
lightwalker-eth
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP