Modernize for MW 1.31 and PHP 7 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnwatts
commented
Nov 15, 2018
jnwatts
commented
- Move to extension.json style
- Replace class constructors with __construct
- Replace addHeadItem with addModules
- Update parser hook callback
- Default to SSL database connection
* Move to extension.json style * Replace class constructors with __construct * Replace addHeadItem with addModules * Update parser hook callback * Default to SSL database connection
|
I don't use this extension anymore and cannot test your changes, because I don't have this setup. If you want to take over the repo (it isn't even originally my code), I can forward users to your fork. |
|
Did you ever make contact with the original author? In their stead, I'd be happy to take up the "semi-official" repository as I've been relying on the extension for a few years now. |
|
I have not really contacted the original author, but as far as I've seen, @ianhomer is aware that the forked repo exists and that it has been maintained a bit longer. I'll add a link to your fork, so people can use your improvements. I'll keep the old repo for some time, but I'll remove it in a year or so. Is it ok? |
|
That'd be fine by me :-) |
The previous modernization commit incorrectly called setHook instead of setFunctionHook. Further, it was apparently not tested at all. This change adds the intended parser function support and corrects the erronous implementation of the tag extension. Invocation can now be either:
{{#bugzillareports arg=val|arg2=val2}}
or
<bugzillareports arg=val arg2=val2 />
PHP 7 removed split function
arg no longer needed
Update Split function and remove unused frame from function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.