Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Security upgrade @storybook/react from 6.5.7 to 7.0.0 #39

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[Snyk] Security upgrade @storybook/react from 6.5.7 to 7.0.0 #39

wants to merge 1 commit into from

Conversation

naiba4
Copy link
Owner

@naiba4 naiba4 commented Jan 10, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
⚠️ Warning 
Failed to update the package-lock.json, please update manually before merging.

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 109/1000
Why? Confidentiality impact: Low, Integrity impact: Low, Availability impact: None, Scope: Changed, Exploit Maturity: Proof of Concept, User Interaction (UI): Required, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.01055, Social Trends: No, Days since published: 0, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: Medium, Package Popularity Score: 99, Impact: 4.54, Likelihood: 2.39, Score Version: V5		 Cross-site Scripting (XSS)
SNYK-JS-SERIALIZEJAVASCRIPT-6147607		 Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @storybook/react The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Scripting (XSS)

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gutenberg ❌ Failed (Inspect) Jan 10, 2024 9:38am
gutenberg-wd9x ❌ Failed (Inspect) Jan 10, 2024 9:38am

@pull-request-quantifier-deprecated Pull Request Quantifier (deprecated)
Copy link

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@socket-security Socket Security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@storybook/react 6.5.7...7.0.0 None +56/-108 206 MB shilman

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Chronological version anomaly react-is 18.1.0
Chronological version anomaly telejson 7.2.0
Uses eval telejson 7.2.0
Chronological version anomaly @types/glob 8.1.0
Debug access esbuild-register 3.5.0
Dynamic require esbuild-register 3.5.0
Environment variable access esbuild-register 3.5.0
Filesystem access esbuild-register 3.5.0
Dynamic require @storybook/core-common 7.0.0
Network access @storybook/core-common 7.0.0
Dynamic require @storybook/react 7.0.0
Minified code @storybook/react 7.0.0
Dynamic require esbuild 0.17.19
Environment variable access esbuild 0.17.19
Filesystem access esbuild 0.17.19
Network access esbuild 0.17.19
No v1 esbuild 0.17.19
Shell access esbuild 0.17.19
Empty package @esbuild/android-arm64 0.17.19
No v1 @esbuild/android-arm64 0.17.19
Empty package @esbuild/darwin-arm64 0.17.19
No v1 @esbuild/darwin-arm64 0.17.19
Empty package @esbuild/darwin-x64 0.17.19
No v1 @esbuild/darwin-x64 0.17.19
Empty package @esbuild/freebsd-arm64 0.17.19
No v1 @esbuild/freebsd-arm64 0.17.19
Empty package @esbuild/freebsd-x64 0.17.19
No v1 @esbuild/freebsd-x64 0.17.19
Empty package @esbuild/linux-arm 0.17.19
No v1 @esbuild/linux-arm 0.17.19
Empty package @esbuild/linux-arm64 0.17.19
No v1 @esbuild/linux-arm64 0.17.19
Empty package @esbuild/linux-ia32 0.17.19
No v1 @esbuild/linux-ia32 0.17.19
Empty package @esbuild/linux-loong64 0.17.19
No v1 @esbuild/linux-loong64 0.17.19
Empty package @esbuild/linux-mips64el 0.17.19
No v1 @esbuild/linux-mips64el 0.17.19
Empty package @esbuild/linux-ppc64 0.17.19
No v1 @esbuild/linux-ppc64 0.17.19
Empty package @esbuild/linux-riscv64 0.17.19
No v1 @esbuild/linux-riscv64 0.17.19
Empty package @esbuild/linux-s390x 0.17.19
No v1 @esbuild/linux-s390x 0.17.19
Empty package @esbuild/linux-x64 0.17.19
No v1 @esbuild/linux-x64 0.17.19
Empty package @esbuild/netbsd-x64 0.17.19
No v1 @esbuild/netbsd-x64 0.17.19
Empty package @esbuild/openbsd-x64 0.17.19
No v1 @esbuild/openbsd-x64 0.17.19
Empty package @esbuild/sunos-x64 0.17.19
No v1 @esbuild/sunos-x64 0.17.19
Empty package @esbuild/win32-arm64 0.17.19
No v1 @esbuild/win32-arm64 0.17.19
Empty package @esbuild/win32-ia32 0.17.19
No v1 @esbuild/win32-ia32 0.17.19
Empty package @esbuild/win32-x64 0.17.19
No v1 @esbuild/win32-x64 0.17.19
Environment variable access dotenv 16.3.1
Major refactor lazy-universal-dotenv 4.0.0
  • Change Percentage: 124.39
  • Current Line Count: 73
  • Previous Line Count: 91
  • Lines Changed: 204
Minified code @storybook/preview-api 7.0.0
Network access @storybook/preview-api 7.0.0
Minified code @storybook/react-dom-shim 7.0.0
  • Confidence: 1.00
  • Location:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naiba4 @snyk-bot