Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neko3 #322

Closed
wants to merge 3 commits into from
Closed

Neko3 #322

wants to merge 3 commits into from

Conversation

rbri
Copy link
Contributor

@rbri rbri commented Apr 11, 2023

the update to neko 3.1.0-SNAPSHOT

There was one regression in neko - so i build fix and made a new snapshot available.
Please check if everything is fine from your side - if yes i will try to make a release as soon as possible.

There is one failing unit test, i guess this is because of some improvements in neko - please check.

@davewichers
Copy link
Collaborator

Thanks for the PR. What happened to this feature: parser.setFeature("http://cyberneko.org/html/features/enforce-strict-attribute-names", true);

When did it exist (in the past) and why did it go away? Was it replaced with some other feature?

@kwwall
Copy link
Contributor

kwwall commented Apr 11, 2023

@davewichers - I think that was part of this commit dc7b646 where @rbri wrote in the commit comment "That feature is no longer supported". Maybe it is no longer needed. This is just speculation, but if you look at the commit ID for Htmlunit at HtmlUnit/htmlunit@641325b on line 135 of com.gargoylesoftware.htmlunit.javascript.host.xml.XSLTProcessor, there is this new code added:

transformerFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);

so perhaps that call replaces the call in AntiSamy that was removed. Like I said, just a guess. @rbri can add an explanation when he has time to comment.

@davewichers
Copy link
Collaborator

@rbri - The 3.1.0-SNAPSHOT works for us. Can you push a new release out ASAP so we can upgrade and do a release too? Thanks!

@rbri
Copy link
Contributor Author

rbri commented Apr 12, 2023

The release is done. Thanks for using neko.

@davewichers
Copy link
Collaborator

I'm merging this by hand from another branch. Thanks for your help!

@rbri rbri deleted the neko3 branch April 12, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants