Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular expressions in antisamy.xml #18

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Conversation

faf0-addepar
Copy link
Contributor

@faf0-addepar faf0-addepar commented Oct 18, 2017

Fix the following regular expressions:

  • paragraph (used for alt and abbr attributes): Questions marks need to be encoded in the used contexts, and must not appear otherwise. Remove the question mark as a permitted character.
  • name attribute regular expression: The - character should be escaped, although in this instance it is not strictly necessary. The _ character is escaped, although it doesn't need to be escaped. Clean up the regular expression by escaping - and not escaping _.

@nahsra
Copy link
Owner

nahsra commented Mar 26, 2019

I think these changes are probably fine, but can you give some examples on why these expressions need to allow these characters? You say "incorrectly", but I'm confused as to what that means. I guess there's a difference between we should "correctly", "legally" and "reasonably" allow.

@faf0-addepar
Copy link
Contributor Author

@nahsra I updated the description of this PR to answer your questions

nahsra added 2 commits June 10, 2020 20:46
dummy commit
i forgot to rebase before trying to kick this off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants