Merge pull request #82 from spassarop/1.6.3

Preserve "!important" on CSS and add some tests
nahsra · Apr 7, 2021 · 43f0308 · 43f0308
2 parents 257830f + d44b01f
commit 43f0308
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/main/java/org/owasp/validator/css/CssHandler.java b/src/main/java/org/owasp/validator/css/CssHandler.java
@@ -498,6 +498,7 @@ public void property(String name, LexicalUnit value, boolean important)
 				styleSheet.append(validator.lexicalValueToString(value));
 				value = value.getNextLexicalUnit();
 			}
+			if (important) { styleSheet.append(" !important"); }
 			styleSheet.append(';');
 			if (!isInline) { styleSheet.append('\n'); }
 

diff --git a/src/test/java/org/owasp/validator/html/test/AntiSamyTest.java b/src/test/java/org/owasp/validator/html/test/AntiSamyTest.java
@@ -1479,5 +1479,16 @@ public void testGithubIssue62() {
             fail(exc.getMessage());
         }
     }
+
+    @Test
+    public void testGithubIssue81() throws ScanException, PolicyException {
+        // Concern is that "!important" is missing after processing CSS
+        assertThat(as.scan("<p style=\"color: red !important\">Some Text</p>", policy, AntiSamy.DOM).getCleanHTML(), containsString("!important"));
+        assertThat(as.scan("<p style=\"color: red !important\">Some Text</p>", policy, AntiSamy.SAX).getCleanHTML(), containsString("!important"));
+
+        // Just to check scan keeps working accordingly without "!important"
+        assertThat(as.scan("<p style=\"color: red\">Some Text</p>", policy, AntiSamy.DOM).getCleanHTML(), not(containsString("!important")));
+        assertThat(as.scan("<p style=\"color: red\">Some Text</p>", policy, AntiSamy.SAX).getCleanHTML(), not(containsString("!important")));
+    }
 }