Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"FrozenError: can't modify frozen String" in lib/httpclient/util.rb:71:in `authority' #395

Open
JasonBarnabe opened this issue Sep 13, 2018 · 0 comments · May be fixed by #398
Open

"FrozenError: can't modify frozen String" in lib/httpclient/util.rb:71:in `authority' #395

JasonBarnabe opened this issue Sep 13, 2018 · 0 comments · May be fixed by #398

Comments

@JasonBarnabe
Copy link

Running my app with RUBYOPT="--enable-frozen-string-literal" gives

FrozenError: can't modify frozen String
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/httpclient-2.8.3/lib/httpclient/util.rb:71:in `authority'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/addressable-2.5.2/lib/addressable/uri.rb:2306:in `to_s'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/addressable-2.5.2/lib/addressable/uri.rb:811:in `initialize'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/addressable-2.5.2/lib/addressable/uri.rb:136:in `new'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/addressable-2.5.2/lib/addressable/uri.rb:136:in `parse'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/httpclient-2.8.3/lib/httpclient/util.rb:154:in `urify'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/httpclient-2.8.3/lib/httpclient/http.rb:195:in `<class:Headers>'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/httpclient-2.8.3/lib/httpclient/http.rb:104:in `<class:Message>'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/httpclient-2.8.3/lib/httpclient/http.rb:98:in `<module:HTTP>'
/Users/jasonbarnabe/.rvm/gems/ruby-2.5.1/gems/httpclient-2.8.3/lib/httpclient/http.rb:19:in `<main>'
JasonBarnabe pushed a commit to kickbooster/httpclient that referenced this issue Nov 27, 2018
Fix error in lib/httpclient/util.rb when frozen strings are enabled.
432877e 
Also fix some of the tests to work with frozen strings. There are still more errors, including sparklemotion/http-cookie#25.

Closes nahi#395
@JasonBarnabe JasonBarnabe linked a pull request Nov 27, 2018 that will close this issue
Open
@darronschall darronschall mentioned this issue Dec 19, 2022
Closed
tsechingho pushed a commit to goldenio/httpclient that referenced this issue Apr 17, 2024
@tsechingho
Fix error in lib/httpclient/util.rb when frozen strings are enabled.
dfa5cd8 
Also fix some of the tests to work with frozen strings. There are still more errors, including sparklemotion/http-cookie#25.

Closes nahi#395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error in lib/httpclient/util.rb when frozen strings are enabled kickbooster/httpclient
1 participant
@JasonBarnabe