Implementation of support for new PHP7 typing features #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is quite the big pull request |
|
It's ok. I hope the implementation will help the project |
nahakiole
reviewed
Sep 22, 2020
| @@ -119,6 +139,13 @@ class PHPCodeGenerator { | |||
| fullPath = basePath + '/' + elem.name + '.php'; | |||
| codeWriter = new codegen.CodeWriter(this.getIndentString(options)); | |||
| codeWriter.writeLine("<?php"); | |||
|
|
|||
| if (options.useStrictTypes === true) { | |||
| codeWriter.writeLine(""); | |||
There was a problem hiding this comment.
It was repeated code before, but with adding more I would either try to get the repeated code into a function or check if it is either a UMLClass, UMLInterface or UMLEnumeration and then output the common header. That would be an improvement, but functionally everything looks great 👍
There was a problem hiding this comment.
As soon as I have some time, I make some improvements to adjust this. Glad it was useful. 👍
nahakiole
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding to issue #3
model-example.zip