Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new major dependency versions #679

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

nagyesta
Copy link
Owner

Issue: #373

Description

  • Updates JDK version of APP module to JDK 17
  • Fixes EC signature cryptography issue caused by deprecation of secp256k1
  • Updates Spring Boot to latest
  • Updates Spring to latest
  • Updates Tomcat to latest
  • Updates Logback to latest
  • Updates Hibernate validator to latest
  • Replaces javax.* packages with jakarta.* in imports
  • Updates controller mappings to have them present with and without trailing slash
  • Adds new test to verify that both request mapping variants are present every time
  • Converts some classes to records
  • Replaces unnecessary getters with Lombok Getter
  • Starts using toList() collector where possible
  • Replaces Spring dependencies with Picocontainer in Cucumber tests
  • Updates Docker base image to use latest JRE 17
  • Updates readmes to indicate accurate Java version of each artifact

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

  • Major update, the Lowkey Vault App requires Java 17 to work after this is merged

@nagyesta nagyesta self-assigned this Aug 18, 2023
@nagyesta nagyesta added the enhancement New feature or request label Aug 18, 2023
- Updates JDK version of APP module to JDK 17
- Fixes EC signature cryptography issue caused by deprecation of secp256k1
- Updates Spring Boot to latest
- Updates Spring to latest
- Updates Tomcat to latest
- Updates Logback to latest
- Updates Hibernate validator to latest
- Replaces javax.* packages with jakarta.* in imports
- Updates controller mappings to have them present with and without trailing slash
- Adds new test to verify that both request mapping variants are present every time
- Converts some classes to records
- Replaces unnecessary getters with Lombok Getter
- Starts using toList() collector where possible
- Replaces Spring dependencies with Picocontainer in Cucumber tests
- Updates Docker base image to use latest JRE 17
- Updates readmes to indicate accurate Java version of each artifact

Resolves #373
{major}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta force-pushed the feature/373-upgrade-to-java-17 branch from 6f0ee5b to e510939 Compare August 18, 2023 22:06
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #679 (e510939) into main (623c8ac) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #679      +/-   ##
============================================
- Coverage     99.06%   99.06%   -0.01%     
+ Complexity     1848     1833      -15     
============================================
  Files           215      216       +1     
  Lines          4685     4683       -2     
  Branches        186      186              
============================================
- Hits           4641     4639       -2     
  Misses           34       34              
  Partials         10       10              
Flag Coverage Δ
app 99.49% <100.00%> (-0.01%) ⬇️
client 94.11% <ø> (ø)
testcontainers 97.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...agyesta/lowkeyvault/controller/PingController.java 100.00% <ø> (ø)
...mmon/CommonCertificateBackupRestoreController.java 100.00% <ø> (ø)
...controller/common/CommonCertificateController.java 100.00% <ø> (ø)
...ller/common/CommonCertificatePolicyController.java 100.00% <ø> (ø)
...oller/common/CommonKeyBackupRestoreController.java 100.00% <ø> (ø)
...eyvault/controller/common/CommonKeyController.java 100.00% <ø> (ø)
...t/controller/common/CommonKeyCryptoController.java 100.00% <ø> (ø)
...er/common/CommonSecretBackupRestoreController.java 100.00% <ø> (ø)
...ault/controller/common/CommonSecretController.java 100.00% <ø> (ø)
...lt/controller/v7_2/KeyBackupRestoreController.java 100.00% <ø> (ø)
... and 59 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nagyesta nagyesta merged commit 568e216 into main Aug 18, 2023
@nagyesta nagyesta deleted the feature/373-upgrade-to-java-17 branch August 18, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant