Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 cannot be decoded to KeyStore with Java client #1296

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

nagyesta
Copy link
Owner

Issue: #1295

Description

  • Fixes encoder to generate same format as before
  • Changes end-to-end tests to only accept the right format (and no longer accept Base64Mime)

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

- Fixes encoder to generate same format as before
- Changes end-to-end tests to only accept the right format (and no longer accept Base64Mime)

Resolves #1295
{patch}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta self-assigned this Dec 29, 2024
@nagyesta nagyesta added the bug Something isn't working label Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.89%. Comparing base (e15a9fb) to head (91a643c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1296   +/-   ##
=========================================
  Coverage     98.89%   98.89%           
  Complexity     2032     2032           
=========================================
  Files           239      239           
  Lines          4965     4965           
  Branches        196      196           
=========================================
  Hits           4910     4910           
  Misses           42       42           
  Partials         13       13           
Flag Coverage Δ
app 99.37% <100.00%> (ø)
client 94.00% <ø> (ø)
testcontainers 96.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit a8f09ca into main Dec 29, 2024
14 checks passed
@nagyesta nagyesta deleted the bugfix/1295-finx-base64-encoding branch December 29, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant